Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

Fix bottom white space#35

Open
Axrorxoja wants to merge 1 commit intoFirebaseExtended:masterfrom
Axrorxoja:fix/remove_bottom_white_space_in_preview
Open

Fix bottom white space#35
Axrorxoja wants to merge 1 commit intoFirebaseExtended:masterfrom
Axrorxoja:fix/remove_bottom_white_space_in_preview

Conversation

@Axrorxoja
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Axrorxoja
Copy link
Author

@googlebot I signed it!

@morganchen12 morganchen12 requested a review from zhouyiself April 7, 2020 20:03
if (childHeight <= layoutHeight) {
for (int i = 0; i < getChildCount(); ++i) {
getChildAt(i).layout(0, 0, childWidth, childHeight);
getChildAt(i).layout(0, 0, childWidth, getHeight());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC matching container's height forcibly will cause the camera frame distortion if the aspect ratio of camera preview is different than the container. For example, camera ratio is 16 : 9 and container ratio is 17 : 9, then this change will stretch the camera frame to have ratio 17 : 9.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants